This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/2] Fix minor glitches with basic asm
- From: Richard Biener <rguenther at suse dot de>
- To: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 7 Dec 2015 09:31:40 +0100 (CET)
- Subject: Re: [PATCH 1/2] Fix minor glitches with basic asm
- Authentication-results: sourceware.org; auth=none
- References: <HE1PR07MB0905430A2598D78BDB2184EEE40A0 at HE1PR07MB0905 dot eurprd07 dot prod dot outlook dot com>
On Sun, 6 Dec 2015, Bernd Edlinger wrote:
>
> Hi,
>
> while looking at the handling of basic asm statements
> I noticed two minor glitches, which I want to fix now.
>
> First there is a missing check in compare_gimple_asm in ipa-icf-gimple.c
>
> Here we check if two asm statements are exactly identical,
> there is a possibility that one is a basic asm and the other is an
> extended asm with zero operands. Even if both have the same string
> the string means something slightly different, if % or { } are around.
>
> example:
>
> asm("%"); // OK
> asm("%":); // error: invalid 'asm': invalid %-code
>
>
> Boot-strapped and reg-tested on x86_64-pc-linux-gnu,
> OK for trunk?
Ok.
Richard.