This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Gimple loop splitting v2
- From: Jeff Law <law at redhat dot com>
- To: Michael Matz <matz at suse dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 5 Dec 2015 00:55:40 -0700
- Subject: Re: Gimple loop splitting v2
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot LSU dot 2 dot 20 dot 1511121734040 dot 11029 at wotan dot suse dot de> <5645083A dot 5070607 at redhat dot com> <alpine dot LSU dot 2 dot 20 dot 1511161453390 dot 11029 at wotan dot suse dot de> <564A6648 dot 6000002 at redhat dot com> <alpine dot LSU dot 2 dot 20 dot 1512011711210 dot 13533 at wotan dot suse dot de> <565E25E7 dot 7050202 at redhat dot com> <alpine dot LSU dot 2 dot 20 dot 1512021420420 dot 13533 at wotan dot suse dot de>
On 12/02/2015 06:23 AM, Michael Matz wrote:
Hi,
On Tue, 1 Dec 2015, Jeff Law wrote:
So, okay for trunk?
-ENOPATCH
Sigh :)
Here it is.
Ciao,
Michael.
* common.opt (-fsplit-loops): New flag.
* passes.def (pass_loop_split): Add.
* opts.c (default_options_table): Add OPT_fsplit_loops entry at -O3.
(enable_fdo_optimizations): Add loop splitting.
* timevar.def (TV_LOOP_SPLIT): Add.
* tree-pass.h (make_pass_loop_split): Declare.
* tree-ssa-loop-manip.h (rewrite_into_loop_closed_ssa_1): Declare.
* tree-ssa-loop-unswitch.c: Include tree-ssa-loop-manip.h,
* tree-ssa-loop-split.c: New file.
* Makefile.in (OBJS): Add tree-ssa-loop-split.o.
* doc/invoke.texi (fsplit-loops): Document.
* doc/passes.texi (Loop optimization): Add paragraph about loop
splitting.
testsuite/
* gcc.dg/loop-split.c: New test.
Index: tree-ssa-loop-split.c
+/* Return true when BB inside LOOP is a potential iteration space
+ split point, i.e. ends with a condition like "IV < comp", which
+ is true on one side of the iteration space and false on the other,
+ and the split point can be computed. If so, also return the border
+ point in *BORDER and the comparison induction variable in IV. */
+
+static tree
+split_at_bb_p (struct loop *loop, basic_block bb, tree *border, affine_iv *iv)
+{
+ gimple *last;
+ gcond *stmt;
+ affine_iv iv2;
+
+
+ /* Make it so, that the first argument of the condition is
+ the looping one (only swap. */
Nit. I don't think you want a comma after "so". And it looks like your
comment got truncated as well.
With the comment above fixed, this is fine for the trunk.
jeff