This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix -Werror= handling for Joined warnings, add a few missing Warning keywords (PRs c/48088, c/68657)
- From: Bernd Schmidt <bschmidt at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, "Joseph S. Myers" <joseph at codesourcery dot com>, Manuel LÃpez-IbÃÃez <lopezibanez at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 4 Dec 2015 18:01:58 +0100
- Subject: Re: [PATCH] Fix -Werror= handling for Joined warnings, add a few missing Warning keywords (PRs c/48088, c/68657)
- Authentication-results: sourceware.org; auth=none
- References: <20151204163729 dot GO5675 at tucnak dot redhat dot com>
I think marking stuff with Warning as appropriate qualifies as obvious.
On 12/04/2015 05:37 PM, Jakub Jelinek wrote:
+ /* If the switch takes an integer, convert it. */
+ if (arg && cl_options[opt_index].cl_uinteger)
+ {
+ value = integral_argument (arg);
+ if (value == -1)
+ return;
+ }
So does this issue an error message anywhere or just silently drop the
option on the floor if the argument is invalid?
+ /* If the switch takes an enumerated argument, convert it. */
+ if (arg && (cl_options[opt_index].var_type == CLVC_ENUM))
Unnecessary parens.
Bernd