This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE
- From: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- Cc: gfortran <fortran at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, David Malcolm <dmalcolm at redhat dot com>
- Date: Tue, 1 Dec 2015 17:12:57 +0100
- Subject: Re: [PATCH] RFC: Use Levenshtein spelling suggestions in Fortran FE
- Authentication-results: sourceware.org; auth=none
- References: <1448974501-30981-1-git-send-email-rep dot dot dot nop at gmail dot com> <1448974501-30981-4-git-send-email-rep dot dot dot nop at gmail dot com> <20151201150153 dot GA20747 at troutmask dot apl dot washington dot edu>
On 1 December 2015 at 16:01, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> On Tue, Dec 01, 2015 at 01:55:01PM +0100, Bernhard Reutner-Fischer wrote:
>>
>> David Malcolm nice Levenshtein distance spelling check helpers
>> were used in some parts of other frontends. This proposed patch adds
>> some spelling corrections to the fortran frontend.
> What problem are you trying to solve here? The patch looks like
The idea is to improve the programmer experience when writing code.
See the testcases enclosed in the patch. I consider this a feature :)
> unneeded complexity with the result of injecting C++ idioms into
> the Fortran FE.
What C++ idioms are you referring to? The autovec?
AFAIU the light use of C++ in GCC is deemed OK. I see usage of
std::swap and std::map in the FE, not to mention the wide-int uses
(wi::). Thus we don't have to realloc/strcat but can use vectors to
the same effect, just as other frontends, including the C frontend,
do.
I take it you remember that we had to change all "try" to something
C++ friendly. If the Fortran FE meant to opt-out of being compiled
with a C++ compiler in the first place, why were all the C++ clashes
rewritten, back then? :)
thanks,