Re: [PR68432 00/26] Handle size/speed choices for internal functions

[Bernd Schmidt <bschmidt at redhat dot com>]

On 11/26/2015 05:22 PM, Richard Sandiford wrote:
> Bernd Schmidt <bschmidt@redhat.com> writes:
>
> > I wish we'd taken some more time to think through the consequences of
> > the original internal_fn patchset.
>
> I don't think this PR shows that the approach was wrong.

I think it does. Internal functions make a new assumptions, that 
expanders don't FAIL - but as we've now seen, they do. The optimize_size 
thing is reasonably easy to grep for and it looks like only i386 is 
affected, but have you looked at every expander in every port that could 
be used by an internal function to ensure it does not FAIL for a 
different reason?

Is there a simple way to disable the entire internal_fn machinery and 
get us back to where we were in gcc-5, without taking out all the code 
immediately? That would give us time until next stage 1 to think through 
the issues.


Bernd