This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL in ipa-pta
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: Tom de Vries <Tom_deVries at mentor dot com>, "gcc-patches at gnu dot org" <gcc-patches at gnu dot org>
- Date: Mon, 30 Nov 2015 14:32:37 +0100
- Subject: Re: [PATCH, PR46032] Handle BUILT_IN_GOMP_PARALLEL in ipa-pta
- Authentication-results: sourceware.org; auth=none
- References: <565C0F47 dot 5020604 at mentor dot com> <alpine dot LSU dot 2 dot 11 dot 1511301010570 dot 4884 at t29 dot fhfr dot qr> <565C3CEC dot 9040209 at mentor dot com> <alpine dot LSU dot 2 dot 11 dot 1511301423530 dot 4884 at t29 dot fhfr dot qr>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Mon, Nov 30, 2015 at 02:24:18PM +0100, Richard Biener wrote:
> > OK for stage3 trunk if bootstrap and reg-test succeeds?
>
> - || node->address_taken);
> + || (node->address_taken
> + && !node->parallelized_function));
>
> please add a comment here on why this is safe.
>
> Ok with this change.
BTW, __builting_GOMP_task supposedly can be treated similarly
if the third argument is NULL (if 3rd arg is non-NULL, then
the caller passes a different structure from what the callee receives,
but perhaps it could be emulated as pretending that cpyfn is called first
with address of a temporary var and the data argument and then fn
is called with the address of the temporary var).
Jakub