This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 5/7][Testsuite] Support ARMv8.1 ARM tests.
- From: Matthew Wahab <matthew dot wahab at foss dot arm dot com>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 27 Nov 2015 17:11:40 +0000
- Subject: Re: [PATCH 5/7][Testsuite] Support ARMv8.1 ARM tests.
- Authentication-results: sourceware.org; auth=none
- References: <56572B79 dot 9000406 at foss dot arm dot com> <56572D23 dot 4050503 at foss dot arm dot com> <56572ED9 dot 2080108 at foss dot arm dot com> <CAKdteOa3g8fjdmT0viFiR4997YyGWitDe_aoT+i6mObVLZcviQ at mail dot gmail dot com>
On 27/11/15 13:44, Christophe Lyon wrote:
On 26/11/15 16:02, Matthew Wahab wrote:
This patch adds ARMv8.1 support to GCC Dejagnu, to allow ARM
tests to specify targest and to set up command line options.
It builds on the ARMv8.1 target support added for AArch64 tests, partly
reworking that support to take into account the different configurations
that tests may be run under.
I may be mistaken, but -mfpu=neon-fp-armv8 and -mfloat-abi=softfp are not
supported by aarch64-gcc. So it seems to me that
check_effective_target_arm_v8_1a_neon_ok_nocache will not always work
for aarch64 after your patch.
Or does it work because no option is needed and thus "" always
matches and thus the loop always exits after the first iteration
on aarch64?
Yes, the idea is that the empty string will make the function first try
'-march=armv8.1-a' without any other flag. That will work for AArch64 because it
doesn't need any other option.
Maybe a more accurate comment would help remembering that, in case
-mfpu option becomes necessary for aarch64.
Agreed, it's worth having a comment to explain what the 'foreach' construct is doing.
Matthew