This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68506: Fix emitting order of insns in IF-THEN-JOIN case

From: Bernd Schmidt <bschmidt at redhat dot com>
To: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 26 Nov 2015 17:49:49 +0100
Subject: Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68506: Fix emitting order of insns in IF-THEN-JOIN case
Authentication-results: sourceware.org; auth=none
References: <5656E924 dot 4030603 at arm dot com> <56570BDB dot 9070804 at redhat dot com> <56570EAA dot 1070808 at arm dot com> <565715D9 dot 4070702 at redhat dot com> <56571895 dot 90809 at arm dot com> <5657372D dot 4080907 at arm dot com>

On 11/26/2015 05:45 PM, Kyrill Tkachov wrote:

         that doesn't help, punt.  */

-  modified_in_a = emit_a != NULL_RTX && modified_in_p (orig_b, emit_a);
    if (tmp_b && then_bb)
      {

These bits I thought would be part of a followup patch (which would alsoguard against single_set problems), and as I mentioned I'd rather have achecking assert.

So take these deletions out and leave them for the followup, and thepatch is ok everywhere. No need for a full retest given that practicallythe same patch has been tested already, just make sure you can build cc1.



Bernd

Follow-Ups:
- Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68506: Fix emitting order of insns in IF-THEN-JOIN case
  - From: Kyrill Tkachov

References:
- [PATCH][RTL-ifcvt] PR rtl-optimization/68506: Fix emitting order of insns in IF-THEN-JOIN case
  - From: Kyrill Tkachov
- Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68506: Fix emitting order of insns in IF-THEN-JOIN case
  - From: Bernd Schmidt
- Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68506: Fix emitting order of insns in IF-THEN-JOIN case
  - From: Kyrill Tkachov
- Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68506: Fix emitting order of insns in IF-THEN-JOIN case
  - From: Bernd Schmidt
- Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68506: Fix emitting order of insns in IF-THEN-JOIN case
  - From: Kyrill Tkachov
- Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68506: Fix emitting order of insns in IF-THEN-JOIN case
  - From: Kyrill Tkachov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]