This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA: PATCH to gimple_canonical_types_compatible_p for middle-end/66214
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Jason Merrill <jason at redhat dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>
- Date: Thu, 26 Nov 2015 10:33:25 +0100
- Subject: Re: RFA: PATCH to gimple_canonical_types_compatible_p for middle-end/66214
- Authentication-results: sourceware.org; auth=none
- References: <5655DA06 dot 4000506 at redhat dot com>
On Wed, Nov 25, 2015 at 4:55 PM, Jason Merrill <jason@redhat.com> wrote:
> The problem here is that we're trying to compare the TYPE_FIELDS of two
> variants of an incomplete type, which doesn't make sense; we shouldn't
> expect TYPE_FIELDS of an incomplete type to be meaningful.
>
> Tested x86_64-pc-linux-gnu. OK for trunk?
Hmm, originally the code wasn't supposed to be called for incomplete types
as you generally can't compare them. But now that the verifier uses the
predicate it instead should have this guard.
Richard.