This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [ARM] neon-testgen.ml typo


On 13 November 2015 at 14:36, Christophe Lyon
<christophe.lyon@linaro.org> wrote:
> On 13 November 2015 at 12:24, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
>>
>> On 13/11/15 11:18, Ramana Radhakrishnan wrote:
>>>>
>>>> Hmm. I hadn't noticed that the crypto intrinsics tests where generated by
>>>> neon-testgen.ml, I thought they were hand-written.
>>>> The tests I added do not cover the crypto intrinsics, so I'm going
>>>> to revert r230274 and restore all the tests generated by neon-testgen.ml
>>>> until we have better coverage in advsimd-intrinsics.
>>>
>>>  From what I remember from a few days back I thought it was generally
>>> ok to get rid of the lot as we had test coverage for everything else
>>> in gcc.target/arm .
>>>
>>> Thus don't bother reverting.
>>
>>
>> +1. I'll also add that you can now remove neon.ml from config/arm.
>
> Sorry, I felt so guilty that I reverted the removal already.
>
>> And also, I think we can move the remaining hand-written tests from
>> gcc.target/arm/neon/
>> into gcc.target/arm/ and remove the neon/ directory altogether.
>>
> I'll give a deeper look at all that, and will try not to rush to meet
> e/o stage1 deadline :-)
>

I've given a look at this in more detail.

I've attached the list of intrinsics that would no longer be tested after
removing the tests generated by neon-testgen.ml.

They are mostly p64 and p128, as well as:
- p8/p16 vreinterpretq. Not sure why they are not in my tests.
- vrnd*
- vtst[q]_p8. Not sure why they are not in my tests

So there is a bit of work to create new tests before removing
the ml-generated ones.

Christophe

>> Kyrill
>>
>>
>>>
>>> Ramana
>>>
>>>> Sorry for the oversight.
>>>>
>>>> Christophe.
>>>>
>>>>
>>>>> Christophe.
>>>>>
>>>>>>> regards
>>>>>>> Ramana
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Christophe.
>>>>>>>>
>>>>>>>>> regards
>>>>>>>>> Ramana
>>
>>

Attachment: neon-not-covered-after-cleanup.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]