This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 1/2] [graphite] Move codegen related functions to graphite-isl-ast-to-gimple.c
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Sebastian Pop <sebpop at gmail dot com>
- Cc: Aditya K <hiraditya at msn dot com>, Aditya Kumar <aditya dot k7 at samsung dot com>, Sebastian Pop <s dot pop at samsung dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 19 Nov 2015 23:42:47 -0500
- Subject: Re: [PATCH 1/2] [graphite] Move codegen related functions to graphite-isl-ast-to-gimple.c
- Authentication-results: sourceware.org; auth=none
- References: <CAGWvnym5-oOTahb5LVYq+9dQ8TojSFEzQ5fQjt03EL6qWZCd7A at mail dot gmail dot com> <BLU179-W597C1632A71D1398F738DCB61B0 at phx dot gbl> <20151119203733 dot GA395 at f1 dot c dot bardezibar dot internal>
The patch fixed the bootstrap failure.
Thanks, David
On Thu, Nov 19, 2015 at 3:37 PM, Sebastian Pop <sebpop@gmail.com> wrote:
> Fixed in r230625.
>
> David, please test on your systems, we were not able to reproduce the fails on
> x86_64-linux: the linker does optimize away the functions that are not used.
>
> Thanks,
> Sebastian
>
> Aditya K wrote:
>> Thanks for the update. I'll fix that asap.
>>
>>
>> -Aditya
>>
>>
>> ----------------------------------------
>> > Date: Thu, 19 Nov 2015 08:36:58 -0500
>> > Subject: Re: [PATCH 1/2] [graphite] Move codegen related functions to graphite-isl-ast-to-gimple.c
>> > From: dje.gcc@gmail.com
>> > To: hiraditya@msn.com; aditya.k7@samsung.com; s.pop@samsung.com
>> > CC: gcc-patches@gcc.gnu.org
>> >
>> > This patch broke bootstrap when ISL is not enabled.
>> >
>> > graphite-isl-ast-to-gimple.c is protected by HAVE_isl but
>> > get_false_edge_from_guard_bb() is used outside of Graphite, including
>> > sese.c, which is not restricted to HAVE_isl.
>> >
>> > Please fix.
>> >
>> > Thanks, David
>>