This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [1/2] OpenACC routine support
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Cesar Philippidis <cesar at codesourcery dot com>
- Cc: Nathan Sidwell <nathan at acm dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 19 Nov 2015 12:23:08 +0100
- Subject: Re: [1/2] OpenACC routine support
- Authentication-results: sourceware.org; auth=none
- References: <5637B1CF dot 5060408 at acm dot org> <5637B7C7 dot 70901 at acm dot org> <20151103153533 dot GQ478 at tucnak dot redhat dot com> <56413AF1 dot 8070101 at acm dot org> <5641808F dot 10302 at codesourcery dot com> <20151110081603 dot GV5675 at tucnak dot redhat dot com> <564CCB29 dot 30909 at codesourcery dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Nov 18, 2015 at 11:02:01AM -0800, Cesar Philippidis wrote:
> static inline void
> cp_ensure_no_oacc_routine (cp_parser *parser)
> {
> - cp_finalize_oacc_routine (parser, NULL_TREE, false, true);
> + if (parser->oacc_routine && !parser->oacc_routine->error_seen)
> + {
> + tree clauses = parser->oacc_routine->clauses;
> + location_t loc = OMP_CLAUSE_LOCATION (TREE_PURPOSE(clauses));
Formatting, missing space before (clauses));
> @@ -19326,7 +19330,11 @@ cp_parser_late_return_type_opt (cp_parser* parser, cp_declarator *declarator,
> declarator->std_attributes
> = cp_parser_late_parsing_omp_declare_simd (parser,
> declarator->std_attributes);
> -
> + if (oacc_routine_p)
> + declarator->std_attributes
> + = cp_parser_late_parsing_oacc_routine (parser,
> + declarator->std_attributes);
> +
Trailing whitespace at the end of line.
Otherwise LGTM.
Jakub