This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 0/2] Levenshtein-based suggestions (v3)
- From: Marek Polacek <polacek at redhat dot com>
- To: Bernd Schmidt <bschmidt at redhat dot com>
- Cc: David Malcolm <dmalcolm at redhat dot com>, Jeff Law <law at redhat dot com>, Richard Biener <richard dot guenther at gmail dot com>, Manuel López-Ibáñez <lopezibanez at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 13 Nov 2015 16:53:05 +0100
- Subject: Re: [PATCH 0/2] Levenshtein-based suggestions (v3)
- Authentication-results: sourceware.org; auth=none
- References: <55FB150C dot 5090105 at redhat dot com> <1446209267-49800-1-git-send-email-dmalcolm at redhat dot com> <56370667 dot 8000005 at redhat dot com> <1447380516 dot 7830 dot 34 dot camel at surprise> <20151113065738 dot GH3185 at redhat dot com> <1447416968 dot 7830 dot 43 dot camel at surprise> <20151113151119 dot GJ3185 at redhat dot com> <56460555 dot 4010909 at redhat dot com>
On Fri, Nov 13, 2015 at 04:44:21PM +0100, Bernd Schmidt wrote:
> On 11/13/2015 04:11 PM, Marek Polacek wrote:
> >Sorry, I changed my mind. Since QUAL_UNION_TYPE is Ada-only thing and
> >we check (RECORD_TYPE || UNION_TYPE) in a lot of places in the C FE,
> >introducing RECORD_OR_UNION_TYPE_P everywhere would unnecessarily slow
> >things down.
>
> I don't think so, the three codes are adjacent so we should be generating
> "(unsigned)(code - RECORD_TYPE) < 3".
Interesting. Yeah, if we change the RECORD_OR_UNION_TYPE_P macro to this
form, then we don't need a separate version for the C FE.
I'll look at this cleanup in the next week.
Marek