This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] Change to argument promotion in fixed conversion library calls

From: Bernd Schmidt <bschmidt at redhat dot com>
To: sellcey at imgtec dot com
Cc: gcc-patches at gcc dot gnu dot org
Date: Tue, 10 Nov 2015 00:33:36 +0100
Subject: Re: [Patch] Change to argument promotion in fixed conversion library calls
Authentication-results: sourceware.org; auth=none
References: <15881f44-1bed-4fda-a47c-45234f9c091e at BAMAIL02 dot ba dot imgtec dot org> <563CFC33 dot 8050004 at redhat dot com> <1446838073 dot 3867 dot 19 dot camel at ubuntu-sellcey> <563CFF8A dot 9050900 at redhat dot com> <1447088342 dot 3867 dot 27 dot camel at ubuntu-sellcey> <56410672 dot 6050807 at redhat dot com> <1447103449 dot 3867 dot 51 dot camel at ubuntu-sellcey>

On 11/09/2015 10:10 PM, Steve Ellcey wrote:

emit_library_call_value_1 has no way of knowing if the promotion should
be signed or unsigned because it has a mode (probably QImode or HImode)
that it knows may need to be promoted to SImode but it has no way to
know if that should be a signed or unsigned promotion because it has no
tree type information about the library call argument types.

Right now it guesses based on the return type but it may guess wrong
when converting an unsigned int to a signed fixed type or visa versa.

That's not quite how I read the code, but it doesn't matter - the lackof a type seems to be a real issue. Since I don't see anything better,please install your patch.



Bernd

References:
- [Patch] Change to argument promotion in fixed conversion library calls
  - From: Steve Ellcey
- Re: [Patch] Change to argument promotion in fixed conversion library calls
  - From: Bernd Schmidt
- Re: [Patch] Change to argument promotion in fixed conversion library calls
  - From: Steve Ellcey
- Re: [Patch] Change to argument promotion in fixed conversion library calls
  - From: Bernd Schmidt
- Re: [Patch] Change to argument promotion in fixed conversion library calls
  - From: Steve Ellcey
- Re: [Patch] Change to argument promotion in fixed conversion library calls
  - From: Bernd Schmidt
- Re: [Patch] Change to argument promotion in fixed conversion library calls
  - From: Steve Ellcey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]