This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 05/12] always define VMS_DEBUGGING_INFO
- From: Trevor Saunders <tbsaunde at tbsaunde dot org>
- To: Jeff Law <law at redhat dot com>
- Cc: Bernd Schmidt <bschmidt at redhat dot com>, tbsaunde+gcc at tbsaunde dot org, gcc-patches at gcc dot gnu dot org
- Date: Mon, 9 Nov 2015 14:29:04 -0500
- Subject: Re: [PATCH 05/12] always define VMS_DEBUGGING_INFO
- Authentication-results: sourceware.org; auth=none
- References: <1447087669-14039-1-git-send-email-tbsaunde+gcc at tbsaunde dot org> <1447087669-14039-6-git-send-email-tbsaunde+gcc at tbsaunde dot org> <5640E729 dot 9010605 at redhat dot com> <5640E98E dot 2040909 at redhat dot com>
On Mon, Nov 09, 2015 at 11:44:30AM -0700, Jeff Law wrote:
> On 11/09/2015 11:34 AM, Bernd Schmidt wrote:
> >In general I think the _DEBUGGING_INFO patches are going to be OK,
> >modulo Jeff's comment about stage 1. I think they shouldn't have been
> >split - it causes numerous unnecessary extra changes, and the
> >intermediate stages look very inconsistent.
I'd actually really rather review them, or really deal with them in any
way, the way they are. Smaller simpler patches that only deal with one
thing are much better. I think the most macros that appear on one line
are 2, so at most you could lower that to 1 change instead of 2, but who
really cares anyway? I guess its not the greatest thing for blame, but
good blame tools should make that a tiny issue since uninteresting changes
are a fact of life, and I'd much rather skip uninteresting changes than
look at a giant change doing many things and wonder why it did one of
them.
> >>-#ifdef VMS_DEBUGGING_INFO
> >>- else if (write_symbols == VMS_DEBUG || write_symbols ==
> >>VMS_AND_DWARF2_DEBUG)
> >>+ else if (VMS_DEBUGGING_INFO
> >>+ && (write_symbols == VMS_DEBUG
> >>+ || write_symbols == VMS_AND_DWARF2_DEBUG))
> >> debug_hooks = &vmsdbg_debug_hooks;
> >>-#endif
> >> #ifdef DWARF2_LINENO_DEBUGGING_INFO
> >> else if (write_symbols == DWARF2_DEBUG)
> >> debug_hooks = &dwarf2_lineno_debug_hooks;
> >>diff --git a/gcc/vmsdbgout.c b/gcc/vmsdbgout.c
> >>index d41d4b2..6dd6878 100644
> >>--- a/gcc/vmsdbgout.c
> >>+++ b/gcc/vmsdbgout.c
> >>@@ -24,7 +24,7 @@ along with GCC; see the file COPYING3. If not see
> >> #include "coretypes.h"
> >> #include "tm.h"
> >>
> >>-#ifdef VMS_DEBUGGING_INFO
> >>+#if VMS_DEBUGGING_INFO
> >> #include "alias.h"
> >> #include "tree.h"
> >> #include "varasm.h"
> >
> >This seems to reference vmsdbg_debug_hooks unconditionally, but as far
> >as I can tell the definition is still guarded by an #if? Does this compile?
> There's an easy way for Trevor to find out. Build a cross for one of the
> VMS targets (there's 3 defined in config-list.mk) :-)
as I said in 0/12 this did go through config-list.mk, and checking again
this does build on alpha-dec-vms.
Trev
>
> jeff