This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix warning in tree-diagnostic.h.

From: Jeff Law <law at redhat dot com>
To: gcc-patches at gcc dot gnu dot org
Date: Fri, 6 Nov 2015 15:16:37 -0700
Subject: Re: [PATCH] Fix warning in tree-diagnostic.h.
Authentication-results: sourceware.org; auth=none
References: <20151102132655 dot GA10770 at linux dot vnet dot ibm dot com> <563795F2 dot 60301 at redhat dot com> <20151103095721 dot GA6923 at linux dot vnet dot ibm dot com>

On 11/03/2015 02:57 AM, Dominik Vogt wrote:

On Mon, Nov 02, 2015 at 09:57:22AM -0700, Jeff Law wrote:

On 11/02/2015 06:26 AM, Dominik Vogt wrote:

The attached patch fixes the annoying warnings generated by
diagnostic_set_last_function.

Can you point out what warning you're fixing?


Sure.  toplec.c calls diagnostic_set_last_function with a NULL
pointer as the second argument, and cp/typeck.c complains about
it.  Ah, it seems the *current* version of Gcc does not generate
the warning, but the old one (4.8.5) I used to compile does.  So,
it may or may not be worth to apply the patch.

It looks like that was changed explicitly in 2014 (see the history ofg++.dg/abi/offsetof.C). I'm not a C++ expert, but it appears this kindof use is considered OK these days.


jeff

Follow-Ups:
- Re: [PATCH] Fix warning in tree-diagnostic.h.
  - From: Dominik Vogt

References:
- [PATCH] Fix warning in tree-diagnostic.h.
  - From: Dominik Vogt
- Re: [PATCH] Fix warning in tree-diagnostic.h.
  - From: Jeff Law
- Re: [PATCH] Fix warning in tree-diagnostic.h.
  - From: Dominik Vogt

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]