This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Handle internal functions in is_tm_pure_call
- From: Richard Sandiford <richard dot sandiford at arm dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Fri, 06 Nov 2015 19:15:22 +0000
- Subject: Handle internal functions in is_tm_pure_call
- Authentication-results: sourceware.org; auth=none
The upcoming changes to use internal functions for things like sqrt
caused a failure in gcc.dg/tm/20100610.c, because we were trying to get
call flags from the null gimple_call_fn of an IFN_SQRT call. We've been
making fairly heavy use of internal functions for a while now so I think
this might be latent.
Tested on x86_64-linux-gnu, aarch64-linux-gnu and arm-linux-gnueabi.
OK to install?
Thanks,
Richard
gcc/
* trans-mem.c (is_tm_pure_call): Use gimple_call_flags for
internal functions.
diff --git a/gcc/trans-mem.c b/gcc/trans-mem.c
index 45bc759..4583bd5 100644
--- a/gcc/trans-mem.c
+++ b/gcc/trans-mem.c
@@ -266,6 +266,9 @@ is_tm_safe (const_tree x)
static bool
is_tm_pure_call (gimple *call)
{
+ if (gimple_call_internal_p (call))
+ return (gimple_call_flags (call) & (ECF_CONST | ECF_TM_PURE)) != 0;
+
tree fn = gimple_call_fn (call);
if (TREE_CODE (fn) == ADDR_EXPR)