This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gomp4] openacc reduction simplification

From: Thomas Schwinge <thomas at codesourcery dot com>
To: Nathan Sidwell <nathan at codesourcery dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 30 Oct 2015 14:14:24 +0100
Subject: Re: [gomp4] openacc reduction simplification
Authentication-results: sourceware.org; auth=none
References: <56328152 dot 5080105 at acm dot org>

Hi Nathan!

On Thu, 29 Oct 2015 13:28:02 -0700, Nathan Sidwell <nathan@acm.org> wrote:
> I've committed this to gomp4.   It removes a no-longer needed field from 
> omp_context &  simplifies the dummy head/tail generation needed for reductions 
> at the outermost level.  Also incorporates the simplification I committed to 
> trunk  earlier today.

> 	* omp-low.c (struct omp_context): Remove reductions field.
> 	(scan_sharing_clauses): Don't increment it.
> 	(lower_omp_target): Don't check it.  Move openacc dummy gang head
> 	& tail generation later & simplify.  Merge ifs.

Thanks for clearing that up.  When working through merge conflicts of a
recent merge from trunk into gomp-4_0-branch, I had noticed the same
oddities (unreachable "if" condition, too complicated reductions
handling), but at that time couldn't allocate time for working on it.

GrÃÃe
 Thomas

Attachment: signature.asc
Description: PGP signature

References:
- [gomp4] openacc reduction simplification
  - From: Nathan Sidwell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]