This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
AW: [PATCH 1/4] -Wmisleading-indentation: don't warn in presence of entirely blank lines
- From: "bernds_cb1 at t-online dot de" <bernds_cb1 at t-online dot de>
- To: David Malcolm <dmalcolm at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: David Malcolm <dmalcolm at redhat dot com>
- Date: Thu, 29 Oct 2015 18:57:49 +0100 (MET)
- Subject: AW: [PATCH 1/4] -Wmisleading-indentation: don't warn in presence of entirely blank lines
- Authentication-results: sourceware.org; auth=none
- References: <1446137381-32748-1-git-send-email-dmalcolm at redhat dot com> <1446137381-32748-2-git-send-email-dmalcolm at redhat dot com>
- Reply-to: "bernds_cb1 at t-online dot de" <bernds_cb1 at t-online dot de>
-----Original-Nachricht-----
Betreff: [PATCH 1/4] -Wmisleading-indentation: don't warn in presence of entirely blank lines
Datum: 2015-10-29T17:49:38+0100
Von: "David Malcolm" <dmalcolm@redhat.com>
> In each case, a blank line separated the guarded code from followup code
> that wasn't guarded, and to my eyes, the blank line makes the meaning of
> the badly-indented code sufficiently clear that it seems unjustified to
> issue a -Wmisleading-indentation warning.
I think you could (barely) make a case for the last one being ok, but I disagree fairly strongly about the other two cases - they are clearly misindented, so why wouldn't we warn?
Bernd