This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 6/9] ENABLE_CHECKING refactoring: generators

From: Jeff Law <law at redhat dot com>
To: Mikhail Maltsev <maltsevm at gmail dot com>, Richard Biener <richard dot guenther at gmail dot com>
Cc: gcc-patches mailing list <gcc-patches at gcc dot gnu dot org>
Date: Thu, 29 Oct 2015 10:29:29 -0600
Subject: Re: [PATCH 6/9] ENABLE_CHECKING refactoring: generators
Authentication-results: sourceware.org; auth=none
References: <56130763 dot 4070206 at gmail dot com> <561308F8 dot 20805 at gmail dot com> <CAFiYyc0KBVMbs_DkF-NKQq3skPsUN6ukbqHqXN4UOCQ2-88kUA at mail dot gmail dot com> <5624317E dot 7050403 at gmail dot com>

On 10/18/2015 05:55 PM, Mikhail Maltsev wrote:

On 10/06/2015 03:56 PM, Richard Biener wrote:

The generators should simply unconditionally check (not in generated
files, of course).
And the generated code parts should use flag_checking.

Richard.


genautomata has some macros similar to tree checks, so I avoided changing them.
genconditions for some reason #undef-s ENABLE_CHECKING in the generated code. I
did not look at it in details, but decided to simply #define CHECKING_P to 0 for
consistency.

As for genextract and gengtype, I followed your recommendations, that is, used
flag_checking instead of CHECKING_P in genextract, and always enable debugging
functions in gengtype.

I committed this with the trivial fixes to the comments after the#else/#endif lines.


Jeff

References:
- [PATCH 1/9] ENABLE_CHECKING refactoring
  - From: Mikhail Maltsev
- [PATCH 6/9] ENABLE_CHECKING refactoring: generators
  - From: Mikhail Maltsev
- Re: [PATCH 6/9] ENABLE_CHECKING refactoring: generators
  - From: Richard Biener
- Re: [PATCH 6/9] ENABLE_CHECKING refactoring: generators
  - From: Mikhail Maltsev

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]