This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR/67682, break SLP groups up if only some elements match
- From: Andrew Pinski <pinskia at gmail dot com>
- To: Alan Lawrence <alan dot lawrence at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 25 Oct 2015 19:55:58 +0800
- Subject: Re: [PATCH] PR/67682, break SLP groups up if only some elements match
- Authentication-results: sourceware.org; auth=none
- References: <1445613635-12306-1-git-send-email-alan dot lawrence at arm dot com> <CAOckXuO5DowtGj3aEtvUKzK1dQZwHDDyw5Mr-u8WP-QP=Oyc-A at mail dot gmail dot com>
On Sun, Oct 25, 2015 at 7:51 PM, Alan Lawrence <alan.lawrence@arm.com> wrote:
> On 23 October 2015 at 16:20, Alan Lawrence <alan.lawrence@arm.com> wrote:
>> diff --git a/gcc/testsuite/gcc.dg/vect/bb-slp-7.c b/gcc/testsuite/gcc.dg/vect/bb-slp-7.c
>> index ab54a48..b012d78 100644
>> --- a/gcc/testsuite/gcc.dg/vect/bb-slp-7.c
>> +++ b/gcc/testsuite/gcc.dg/vect/bb-slp-7.c
>> @@ -16,12 +16,12 @@ main1 (unsigned int x, unsigned int y)
>> unsigned int *pout = &out[0];
>> unsigned int a0, a1, a2, a3;
>>
>> - /* Non isomorphic. */
>> + /* Non isomorphic, even 64-bit subgroups. */
>> a0 = *pin++ + 23;
>> - a1 = *pin++ + 142;
>> + a1 = *pin++ * 142;
>> a2 = *pin++ + 2;
>> a3 = *pin++ * 31;
>
> Erm, oops, I seem to have posted a version without the corresponding
> change to result-checking in bb-slp-7.c...
>
> Also on second thoughts a small change to improve efficiency
> of the recursion by skipping some known-impossible bits, would not add
> much complexity.
>
> So I'll post a new version shortly with those changes.
Maybe it is better to make a new test for the changed file and keep
the old one with the updated result checking?
That way the testcase is the same between versions and the only thing
that changes is the result checking.
Thanks,
Andrew
>
> Thanks, Alan