This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] gcc/fold-const.c: Correct the report warning position.
- From: Chen Gang <xili_gchen_5257 at hotmail dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>, Jeff Law <law at redhat dot com>
- Cc: gcc-patches List <gcc-patches at gcc dot gnu dot org>, Richard Henderson <rth at redhat dot com>, Iain Buclaw <ibuclaw at gdcproject dot org>, Mike Stump <mikestump at comcast dot net>
- Date: Sat, 24 Oct 2015 08:15:14 +0800
- Subject: Re: [PATCH] gcc/fold-const.c: Correct the report warning position.
- Authentication-results: sourceware.org; auth=none
- References: <55E1AC37 dot 2080002 at hotmail dot com> <COL130-W190CAF81FE19B998AA0C9DB96D0 at phx dot gbl> <CAFiYyc3_3ju-FtZ-FeXjxKHwORXPwCUhcqrAc3ugH0r0bKCE-w at mail dot gmail dot com> <55E5AB8A dot 60408 at hotmail dot com> <COL130-W36E98059AFECBD0A0E5F05B96A0 at phx dot gbl> <BLU437-SMTP249F3E6171D70896DA7550B9310 at phx dot gbl> <BLU436-SMTP1267CA9680AB6AFA59F355B9380 at phx dot gbl> <56293D18 dot 8050502 at redhat dot com> <CAFiYyc2ewQG-XeE2RvqYXmeAHNaBWvZmxKa_JPuTcH7fHN7FFA at mail dot gmail dot com>
On 10/23/15 16:56, Richard Biener wrote:
> On Thu, Oct 22, 2015 at 9:46 PM, Jeff Law <law@redhat.com> wrote:
>>
>> Note that the call to fold_binary from tree-ssa-sccvn.c has been removed.
>> So that hunk either needs to be removed or the change applied elsewhere.
>>
Oh, really, it uses gimple_simplify instead of.
>> I think passing around the location through fold-const.c is OK.
>>
OK, thanks.
>> I'd like to see a testcase in a form ready for inclusion into the testsuite.
OK, thanks, I shall try.
>
> As an additional remark - I'd like to see us not use input_location
> but always loc,
For me, it sounds reasonable.
> even if UNKNOWN_LOCATION. The diagnostic machinery should handle this
> correctly(?). That is, if bootstrap/testign doesn't show testsuite
> regressions because
> of this.
>
I will try.
Hope I can finish trying above all within 2 days (2015-10-25).
Thanks.
--
Chen Gang (éå)
Open, share, and attitude like air, water, and life which God blessed