This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: config header file reduction patch checked in.
- From: Mike Stump <mikestump at comcast dot net>
- To: Andrew MacLeod <amacleod at redhat dot com>
- Cc: Bernd Schmidt <bschmidt at redhat dot com>, Iain Sandoe <iain at codesourcery dot com>, Jeff Law <law at redhat dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>, Dominique Dhumieres <dominiq at lps dot ens dot fr>
- Date: Fri, 23 Oct 2015 10:47:22 -0700
- Subject: Re: config header file reduction patch checked in.
- Authentication-results: sourceware.org; auth=none
- References: <560DEA79 dot 8050709 at redhat dot com> <560DECE1 dot 5080807 at redhat dot com> <56159676 dot 6050405 at redhat dot com> <5616717F dot 8040306 at redhat dot com> <561B698C dot 8060801 at redhat dot com> <562154BA dot 2030209 at redhat dot com> <688F1D44-78EA-40FD-A000-A2E611C24CFE at codesourcery dot com> <56251212 dot 9050504 at redhat dot com> <562A6706 dot 1010907 at redhat dot com> <9F61532C-63DE-44B1-8E6D-ACC125C3C86A at comcast dot net> <562A6D52 dot 10004 at redhat dot com> <562A701E dot 5080400 at redhat dot com>
On Oct 23, 2015, at 10:36 AM, Andrew MacLeod <amacleod@redhat.com> wrote:
>
> darwin-driver.c had some code that depended on one of the include files, bit no other part of the file needed it, so that was the issue there. The only other place it seems could be an issue is with collect2.c... so I'll monitor that one closely before checking anything in.. and get the darwin guys to test it for me before committing.
I’m fine with checking it in on the assumption darwin won’t break here. If it does, I think it will be trivial to clean it up. Just watch out for any darwin doesn’t build due to missing decls or some such and let them know what header needs to be included in darwin.h based upon the missing decls. I faced one of these recently with my port as the headers flexed. Annoying, but not too hard to recover from.