This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, VECTOR ABI] Add __attribute__((__simd__)) to GCC.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Kirill Yukhin <kirill dot yukhin at gmail dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, Jeff Law <law at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 23 Oct 2015 14:16:38 +0000
- Subject: Re: [PATCH, VECTOR ABI] Add __attribute__((__simd__)) to GCC.
- Authentication-results: sourceware.org; auth=none
- References: <20151005130733 dot GB62312 at msticlxl57 dot ims dot intel dot com> <alpine dot DEB dot 2 dot 10 dot 1510051320120 dot 16355 at digraph dot polyomino dot org dot uk> <561551B0 dot 70507 at redhat dot com> <20151014123601 dot GA38813 at msticlxl57 dot ims dot intel dot com> <alpine dot DEB dot 2 dot 10 dot 1510141335490 dot 15356 at digraph dot polyomino dot org dot uk> <20151015143328 dot GA2191 at msticlxl57 dot ims dot intel dot com> <20151015143909 dot GF478 at tucnak dot redhat dot com> <20151015144739 dot GB2191 at msticlxl57 dot ims dot intel dot com> <20151022115151 dot GA58371 at msticlxl57 dot ims dot intel dot com> <alpine dot DEB dot 2 dot 10 dot 1510221246280 dot 32382 at digraph dot polyomino dot org dot uk> <20151023141102 dot GA63293 at msticlxl57 dot ims dot intel dot com>
On Fri, 23 Oct 2015, Kirill Yukhin wrote:
> > You need to update this patch to take account of Marek's fix for bug 67964
> > (it was because I was suspicious of the "continue;" in this patch
> > accepting invalid syntax that I found that bug), retest and resubmit.
> I've rebased the patch on top of current trunk.
This isn't taking proper account of Marek's fix.
> @@ -3993,6 +4001,12 @@ c_parser_attributes (c_parser *parser)
> break;
> continue;
> }
> + if (is_attribute_p ("simd", attr_name))
> + {
> + parser->simd_attr_present = 1;
> + c_parser_consume_token (parser);
> + continue;
> + }
Any such continue needs first to break if the next token isn't a comma;
otherwise you accept bad syntax with no comma between successive
attributes.
--
Joseph S. Myers
joseph@codesourcery.com