This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Don't dump low gimple functions in gimple dump
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Tom de Vries <Tom_deVries at mentor dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, Thomas Schwinge <thomas at codesourcery dot com>, Jan Hubicka <hubicka at ucw dot cz>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Julian Brown <julian at codesourcery dot com>
- Date: Thu, 22 Oct 2015 15:11:46 +0200
- Subject: Re: Don't dump low gimple functions in gimple dump
- Authentication-results: sourceware.org; auth=none
- References: <87k3bnecq3 dot fsf at schwinge dot name> <537B0F6D dot 7060808 at mentor dot com> <87617mndrv dot fsf at kepler dot schwinge dot homeip dot net> <CAFiYyc1i2GAj7JA2Ao1NSxT=oAy83uvVboYcvxGcUe69h-tsvA at mail dot gmail dot com> <55706892 dot 8050701 at mentor dot com> <20151022122717 dot GO478 at tucnak dot redhat dot com> <5628DBD6 dot 3040204 at mentor dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Oct 22, 2015 at 02:51:34PM +0200, Tom de Vries wrote:
> On 22/10/15 14:27, Jakub Jelinek wrote:
> >The state before the patch is:
> >1) the omp_fn children created during the pre-SSA ompexp pass are dumped
> > first in the *.ssa dump and in all the following ones (these are created
> > as low gimple, non-SSA)
>
> Hi,
>
> I do see those child fns before the ssa dump, in the fixup_cfg1 dump (and
> with -fipa-tree-all, also in the visibility dump, just after the ompexp
> dump).
Oh, indeed. Any case, I think, with the patch 1) behaves the most desirable
way now, no dumps before ompexp show it, and ompexp dump shows both the new
child functions and original function with the outlined code already
removed. And all dumps after ompexp show both as well.
> [ Not that I disagree with dumping the child fn in ompexp dump. ]
>
> >2) the omp_cpyfn children created during the pre-SSA ompexp pass are dumped
> > first in the *.omplower dump and in all the following ones (these are
> > created as high gimple)
And this is probably fine too, as the cpyfn functions are artificially
created, they don't contain code that has been moved from somewhere else.
> >3) the omp_fn children created during the parloops/ompexpssa passes
> > are dumped first post-IPA (or during IPA?) and in all the following ones
> > (these are created as SSA gimple)
Bet what you'd want most would be to be able to create new functions and
mark them not just as SSA low gimple, but also be able to say, skip
everything in the pass pipeline for these functions until pass this and
this, i.e. start pass pipeline with pass->next of the creating pass.
Then it would neither show up in the earlier dumps, nor be processed
multiple times by the same passes. We'd need the && !gimple_in_ssa_p
I've added in the patch removed once that is done...
Jakub