This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Hi Tom! On Fri, 16 Oct 2015 11:17:25 +0200, Tom de Vries <Tom_deVries@mentor.com> wrote: > this patch checks for occurance of oacc offload regions in oacc routines > (which means nested parallelism, which is currently not supported) and > gives an appropriate error message. > --- /dev/null > +++ b/gcc/testsuite/c-c++-common/goacc/parallel-in-routine.c > @@ -0,0 +1,8 @@ > +#pragma acc routine > +void > +foo (void) > +{ > +#pragma acc parallel /* { dg-error "OpenACC region inside of OpenACC routine, nested parallelism not supported yet" } */ > + ; > +} Please move such tests into gcc/testsuite/c-c++-common/goacc/nesting-fail-1.c and/or gcc/testsuite/c-c++-common/goacc-gomp/nesting-fail-1.c, and nesting tests that are expected to succeed into gcc/testsuite/c-c++-common/goacc/nesting-1.c and/or gcc/testsuite/c-c++-common/goacc-gomp/nesting-1.c. (I have not looked up the corresponding Fortran testsuite files.) When fixing that, please also add back (checking for appropriate diagnostics) the tests that Nathan apparently didn't know where to put, and thus removed, in <http://news.gmane.org/find-root.php?message_id=%3C56192805.6090200%40acm.org%3E> (gomp-4_0-branch r228678), and <http://news.gmane.org/find-root.php?message_id=%3C561AE027.9040601%40acm.org%3E> (gomp-4_0-branch r228694). GrÃÃe Thomas
Attachment:
signature.asc
Description: PGP signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |