This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v2 10/13] Avoid CSE of MEMs in different address spaces
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Richard Henderson <rth at redhat dot com>
- Cc: Jeff Law <law at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 22 Oct 2015 09:43:07 +0200
- Subject: Re: [PATCH v2 10/13] Avoid CSE of MEMs in different address spaces
- Authentication-results: sourceware.org; auth=none
- References: <1445376433-14658-1-git-send-email-rth at redhat dot com> <1445376433-14658-11-git-send-email-rth at redhat dot com> <56279514 dot 8020605 at redhat dot com> <5627C764 dot 2000505 at redhat dot com>
On Wed, Oct 21, 2015 at 7:12 PM, Richard Henderson <rth@redhat.com> wrote:
> On 10/21/2015 03:37 AM, Jeff Law wrote:
>>
>> On 10/20/2015 03:27 PM, Richard Henderson wrote:
>>>
>>> ---
>>> gcc/cselib.c | 22
>>> +++++++++++++---------
>>> gcc/fold-const.c | 14 +++++++-------
>>> gcc/testsuite/gcc.target/i386/addr-space-2.c | 11 +++++++++++
>>> 3 files changed, 31 insertions(+), 16 deletions(-)
>>> create mode 100644 gcc/testsuite/gcc.target/i386/addr-space-2.c
>>
>> This part is fine. Does the one testcase cover both the cselib.c &
>> fold-const.c fix? If not, it'd be good to cover both if we can.
>
>
> Yes it does.
>
> The fold-const fix gets us as far as .optimized, but then the cselib fix
> gets us past postreload-cse.
These fixes are appropriate for backporting as well I think.
Richard.
>
> r~