This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/9] ENABLE_CHECKING refactoring: libcpp
- From: Jeff Law <law at redhat dot com>
- To: Bernd Schmidt <bschmidt at redhat dot com>, Mikhail Maltsev <maltsevm at gmail dot com>, gcc-patches mailing list <gcc-patches at gcc dot gnu dot org>, Richard Biener <richard dot guenther at gmail dot com>
- Date: Wed, 21 Oct 2015 15:19:12 -0600
- Subject: Re: [PATCH 2/9] ENABLE_CHECKING refactoring: libcpp
- Authentication-results: sourceware.org; auth=none
- References: <56130763 dot 4070206 at gmail dot com> <561307B6 dot 7000707 at gmail dot com> <5613C145 dot 70602 at redhat dot com>
On 10/06/2015 06:40 AM, Bernd Schmidt wrote:
I'm not entirely sure what to make of this series. There seem to be good
bits in there but also some things I find questionable. I'll add some
comments on things that occur to me.
On 10/06/2015 01:28 AM, Mikhail Maltsev wrote:
* include/line-map.h: Fix use of ENABLE_CHECKING.
Fix how? What's wrong with it?
I think it was just a poor choice of words for the ChangeLog.
Probably a good thing, but it looks like libcpp has grown its own
variant linemap_assert; we should check whether that can be replaced.
Agreed. Let's push it onto the queue of things to clean up.
jeff