This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 10/13] Avoid CSE of MEMs in different address spaces

From: Richard Henderson <rth at redhat dot com>
To: Jeff Law <law at redhat dot com>, gcc-patches at gcc dot gnu dot org
Cc: richard dot guenther at gmail dot com
Date: Wed, 21 Oct 2015 07:12:04 -1000
Subject: Re: [PATCH v2 10/13] Avoid CSE of MEMs in different address spaces
Authentication-results: sourceware.org; auth=none
References: <1445376433-14658-1-git-send-email-rth at redhat dot com> <1445376433-14658-11-git-send-email-rth at redhat dot com> <56279514 dot 8020605 at redhat dot com>

On 10/21/2015 03:37 AM, Jeff Law wrote:

On 10/20/2015 03:27 PM, Richard Henderson wrote:

---
  gcc/cselib.c                                 | 22 +++++++++++++---------
  gcc/fold-const.c                             | 14 +++++++-------
  gcc/testsuite/gcc.target/i386/addr-space-2.c | 11 +++++++++++
  3 files changed, 31 insertions(+), 16 deletions(-)
  create mode 100644 gcc/testsuite/gcc.target/i386/addr-space-2.c

This part is fine.  Does the one testcase cover both the cselib.c &
fold-const.c fix?  If not, it'd be good to cover both if we can.


Yes it does.

The fold-const fix gets us as far as .optimized, but then the cselib fix getsus past postreload-cse.

r~

Follow-Ups:
- Re: [PATCH v2 10/13] Avoid CSE of MEMs in different address spaces
  - From: Richard Biener

References:
- [PATCH v2 00/13] Address space support for x86
  - From: Richard Henderson
- [PATCH v2 10/13] Avoid CSE of MEMs in different address spaces
  - From: Richard Henderson
- Re: [PATCH v2 10/13] Avoid CSE of MEMs in different address spaces
  - From: Jeff Law

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]