This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][Testsuite] Add --param sra-max-scalarization-size-Ospeed to sra-12.c

From: Jeff Law <law at redhat dot com>
To: Alan Lawrence <alan dot lawrence at arm dot com>, gcc-patches at gcc dot gnu dot org
Cc: kyrylo dot tkachov at arm dot com, ramana dot radhakrishnan at arm dot com, mikestump at comcast dot net, ro at CeBiTec dot Uni-Bielefeld dot DE
Date: Wed, 21 Oct 2015 09:59:47 -0600
Subject: Re: [PATCH][Testsuite] Add --param sra-max-scalarization-size-Ospeed to sra-12.c
Authentication-results: sourceware.org; auth=none
References: <1445442727-9557-1-git-send-email-alan dot lawrence at arm dot com>

On 10/21/2015 09:52 AM, Alan Lawrence wrote:

gcc.dg/tree-ssa/sra-12.c is skipped on a bunch of targets, including AArch64,
because the default max-scalarization-size depends on MOVE_RATIO, and on those
targets thus ends up being too small for SRA to optimize the testcase. Recently
I noticed that the test has been failing for some time on ARM too. This patch
fixes the test on ARM, AArch64, avr, and sh, and by extension I believe also on
nds32, although I haven't managed to build a nds32 compiler to check.

There is an argument that instead we should skip the test on ARM too; or rather,
since at least ARM and AArch64 would like the test to pass, we should xfail it
on those platforms until we have time to experiment with the threshold/param for
SRA. I hope to do some more investigation on that front as part of (or followup
to) PR/63679.

Is this OK for trunk?

Cheers,
Alan

gcc/testsuite/ChangeLog:

	* gcc.dg/tree-ssa/sra-12.c: Enable test on all targets; add --param
	sra-max-scalarization-size-Ospeed.

OK.
jeff

References:
- [PATCH][Testsuite] Add --param sra-max-scalarization-size-Ospeed to sra-12.c
  - From: Alan Lawrence

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]