This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] 2015-10-15 Benedikt Huber <benedikt dot huber at theobroma-systems dot com> Philipp Tomsich <philipp dot tomsich at theobroma-systems dot com>
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Benedikt Huber <benedikt dot huber at theobroma-systems dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, philipp dot tomsich at theobroma-systems dot com, Venkataramanan dot Kumar at amd dot com, pinskia at gmail dot com, e dot menezes at samsung dot com, Kyrill Tkachov <kyrylo dot tkachov at arm dot com>, Richard dot Earnshaw at foss dot arm dot com, James Greenhalgh <james dot greenhalgh at arm dot com>
- Date: Fri, 16 Oct 2015 10:29:03 +0100
- Subject: Re: [PATCH] 2015-10-15 Benedikt Huber <benedikt dot huber at theobroma-systems dot com> Philipp Tomsich <philipp dot tomsich at theobroma-systems dot com>
- Authentication-results: sourceware.org; auth=none
- References: <20151009114449 dot GA10390 at arm dot com> <1444946596-1824-1-git-send-email-benedikt dot huber at theobroma-systems dot com> <1444946596-1824-2-git-send-email-benedikt dot huber at theobroma-systems dot com>
Hi,
A few more style nits:
> + builtin_decls_data bdda[] = {
New line before {
> + {double_type_node, "__builtin_aarch64_rsqrt_df", AARCH64_BUILTIN_RSQRT_DF},
Space after {
Space before }
> +void aarch64_emit_swrsqrt (rtx, rtx);
> +
> +tree aarch64_builtin_rsqrt (unsigned int fn, bool md_fn);
> +
Drop the formal argument names as you did in the first declaration.
See my previous comment w.r.t the naming of new test cases in
gcc.target/aarch64, at least the following still need s/-/_/
> diff --git a/gcc/testsuite/gcc.target/aarch64/rsqrt-asm-check-common.h b/gcc/testsuite/gcc.target/aarch64/rsqrt-asm-check-common.h
> diff --git a/gcc/testsuite/gcc.target/aarch64/rsqrt-asm-check-negative_1.c b/gcc/testsuite/gcc.target/aarch64/rsqrt-asm-check-negative_1.c
> diff --git a/gcc/testsuite/gcc.target/aarch64/rsqrt-asm-check_1.c b/gcc/testsuite/gcc.target/aarch64/rsqrt-asm-check_1.c
> +// With -ffast-math these return positive INF.
> +// t_double (-0.0, -inf);
> +// t_float (-0.0, -inff);
> +
> +// The reason here is that -ffast-math flushes to zero.
> +// t_double (__DBL_MIN__/256, 0X1.00000000000000P+515);
> +// t_float (__FLT_MIN__/256, 0X1.00000000000000P+67);
Comment consistently with the rest of the backend ie /* */
Thanks
/Marcus