This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH ARM]: PR67745: Fix function alignment after __attribute__ 2/2

On 10/08/2015 03:50 PM, Christian Bruel wrote:

Humm, I don't know what kind of alignment optimization for functions we
have based on a declaration only. greping DECL_ALIGN on functions there
are some bits in the ipa-icf code that seems to merge code using this
information, but I think we have a definition at that point.
but honestly, I'm very unfamiliar with this pass. Do you have something
else in mind ?
I had a vague memory of us optimizing that, but I can't find the code either and maybe it's just not there. That doesn't mean someone isn't going to add it in the future, and I'm uncomfortable leaving incorrect DECL_ALIGN values around.
It looks like rest_of_decl_compilation may be a good place to take care of declarations, but using FUNCTION_BOUNDARY is probably going to give the wrong results. So maybe a target hook, function_boundary_for_decl, defaulting to just returning FUNCTION_BOUNDARY? Eventually it could replace the macro entirely. 


Bernd
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]