This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Mikael Morin <mikael dot morin at sfr dot fr>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Sat, 3 Oct 2015 12:08:56 -0700
- Subject: Re: [PATCH] fortran/67758 -- Prevent ICE caused by misplaced COMMON
- Authentication-results: sourceware.org; auth=none
- References: <20151001000630 dot GB73614 at troutmask dot apl dot washington dot edu> <20151001000740 dot GC73614 at troutmask dot apl dot washington dot edu> <560D240C dot 5070405 at sfr dot fr> <560D3521 dot 5050406 at sfr dot fr> <20151001163040 dot GA77294 at troutmask dot apl dot washington dot edu> <560E4E26 dot 6000302 at sfr dot fr> <20151002164442 dot GB12835 at troutmask dot apl dot washington dot edu> <560FAA38 dot 1080008 at sfr dot fr>
On Sat, Oct 03, 2015 at 12:13:12PM +0200, Mikael Morin wrote:
>
> I have finally managed to find a patch that doesn't regress in the
> testsuite.
>
> The gfc_add_in_common call in gfc_match_common is delayed after the
> array spec handling and without return value check, so that errors are
> ignored. Another gfc_add_in_common call is necessary to report errors
> again during resolution. This is patch number 2.
> The error location for the second call is grabbed from the common block
> struct, which is made accessible in the function by patch number 1.
>
> No regression on x86-unknown-linux-gnu, OK for trunk?
>
The patch is OK. Thanks for taking over PR.
--
Steve