This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch AArch64] Use default_elf_asm_named_section instead of special cased hook
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- Cc: Ramana Radhakrishnan <ramana dot radhakrishnan at foss dot arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 2 Oct 2015 18:40:38 +0200
- Subject: Re: [Patch AArch64] Use default_elf_asm_named_section instead of special cased hook
- Authentication-results: sourceware.org; auth=none
- References: <20151002100806 dot GA18049 at e105545-lin> <CAFqB+Py_fimyiJL2KikK=V5ptn_uORTCDNp24DweG+do7s7CnA at mail dot gmail dot com> <560E8016 dot 2040701 at foss dot arm dot com> <CAFqB+PytNUoHV5nswBayzn360-RfTVix5D8Hi87h9JPTST2psw at mail dot gmail dot com>
On 2 October 2015 at 15:05, Marcus Shawcroft <marcus.shawcroft@gmail.com> wrote:
> On 2 October 2015 at 14:01, Ramana Radhakrishnan
> <ramana.radhakrishnan@foss.arm.com> wrote:
>
>>>> #undef TARGET_ASM_NAMED_SECTION
>>>> -#define TARGET_ASM_NAMED_SECTION aarch64_elf_asm_named_section
>>>> +#define TARGET_ASM_NAMED_SECTION default_elf_asm_named_section
>>>
>>> Isn't it sufficient to simply remove the #define completely and rely
>>> on the default from elfos.h?
>>
>> Doh ! you're right - Yeah should be coming in from config/elfos.h given that we don't support anything other than elf in the aarch64 port.
>>
>> Ok to commit without that hunk ?
>
> Yes. /Marcus
Hi Ramana,
Since this commit, I am seeing build failures when creating lto1:
libbackend.a(aarch64.o):(.data+0x118): undefined reference to
`aarch64_elf_asm_named_section(char const*, unsigned int, tree_node*)'
(targets aarch64_none-linux-gnu and aarch64-none-elf).
I guess I'm missing something obvious?
Christophe.