This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] DWARF support for AIX v4


>> +  else if (TARGET_XCOFF && GET_CODE (x) == SYMBOL_REF
>> +          && SYMBOL_REF_TLS_MODEL (x) != 0)
>> +    {
>> +      if (SYMBOL_REF_TLS_MODEL (x) == TLS_MODEL_LOCAL_EXEC)
>> +       fputs ("@le", file);
>> +      else if (SYMBOL_REF_TLS_MODEL (x) == TLS_MODEL_INITIAL_EXEC)
>> +       fputs ("@ie", file);
>> +      else if (SYMBOL_REF_TLS_MODEL (x) == TLS_MODEL_GLOBAL_DYNAMIC
>> +              || SYMBOL_REF_TLS_MODEL (x) == TLS_MODEL_LOCAL_DYNAMIC)
>> +       fputs ("@m", file);
>> +    }
>
> FWIW, I would have written this:
>
>
>     else if (TARGET_XCOFF && GET_CODE (x) == SYMBOL_REF)
>       {
>         switch (SYMBOL_REF_TLS_MODEL (x))
>           {
>           case 0:
>             break;
>           case TLS_MODEL_LOCAL_EXEC:
>             fputs ("@le", file);
>             break;
>           case TLS_MODEL_INITIAL_EXEC:
>             fputs ("@ie", file);
>             break;
>           case TLS_MODEL_GLOBAL_DYNAMIC:
>           case TLS_MODEL_LOCAL_DYNAMIC:
>             fputs ("@m", file);
>             break;
>           default:
>             gcc_unreachable ();
>           }
>       }

Okay, I will retest with that.

I separately have some good news and some bad news.
Good news: AIX added support for the initially missing DWARF sections.
Bad news: The support is in an AIX service pack whose presence on a
system requires effort to determine.

Thanks, David


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]