This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[gomp4] force global locks for nvptx targets
- From: Cesar Philippidis <cesar at codesourcery dot com>
- To: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: Nathan Sidwell <nathan_sidwell at mentor dot com>
- Date: Tue, 8 Sep 2015 13:02:26 -0700
- Subject: [gomp4] force global locks for nvptx targets
- Authentication-results: sourceware.org; auth=none
This patch forces GOACC_LOCK to use locks in global memory regardless if
the lock us for a worker or a gang. We were using a shared memory for
worker locks, but we ran into an issue with that would sporadically
involve deadlocks in worker reductions. We're still investigating that
issue, but for the time being, global locks appear to work albeit with a
lock contention penalty.
I've applied this patch to gomp-4_0-branch.
Cesar
2015-09-08 Cesar Philippidis <cesar@codesourcery.com>
gcc/
* config/nvptx/nvptx.c (force_global_lock): New global variable.
(nvptx_expand_oacc_lock): Use it to workaround a shared memory lock
problem.
(nvptx_xform_lock): Likewise.
diff --git a/gcc/config/nvptx/nvptx.c b/gcc/config/nvptx/nvptx.c
index 51f2893..c8f6f5c 100644
--- a/gcc/config/nvptx/nvptx.c
+++ b/gcc/config/nvptx/nvptx.c
@@ -134,6 +134,9 @@ static const unsigned lock_level[] = {BARRIER_GLOBAL, BARRIER_SHARED};
static GTY(()) rtx lock_syms[LOCK_MAX];
static bool lock_used[LOCK_MAX];
+/* FIXME: Temporary workaround for worker locks. */
+static bool force_global_locks = true;
+
/* Size of buffer needed for worker reductions. This has to be
disjoing from the worker broadcast array, as both may be live
concurrently. */
@@ -1245,6 +1248,7 @@ nvptx_expand_oacc_lock (rtx src, int direction)
rtx pat;
kind = INTVAL (src) == GOMP_DIM_GANG ? LOCK_GLOBAL : LOCK_SHARED;
+ kind = force_global_locks ? LOCK_GLOBAL : kind;
lock_used[kind] = true;
rtx mem = gen_rtx_MEM (SImode, lock_syms[kind]);
@@ -3740,7 +3744,7 @@ nvptx_xform_lock (gimple stmt, const int *ARG_UNUSED (dims), unsigned ifn_code)
return mode > GOMP_DIM_WORKER;
case IFN_GOACC_LOCK_INIT:
- return mode != GOMP_DIM_WORKER;
+ return force_global_lock || mode != GOMP_DIM_WORKER;
default: gcc_unreachable();
}