This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 3/3] [gomp] Add thread attribute customization
- From: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 3 Sep 2015 13:36:35 +0200
- Subject: Re: [PATCH 3/3] [gomp] Add thread attribute customization
- Authentication-results: sourceware.org; auth=none
- References: <1438081499-9651-1-git-send-email-sebastian dot huber at embedded-brains dot de> <1438081499-9651-3-git-send-email-sebastian dot huber at embedded-brains dot de> <20150903101931 dot GS1847 at tucnak dot redhat dot com> <55E827B1 dot 3020602 at embedded-brains dot de> <20150903110541 dot GT1847 at tucnak dot redhat dot com> <55E82A63 dot 6050504 at embedded-brains dot de> <20150903111050 dot GU1847 at tucnak dot redhat dot com>
On 03/09/15 13:10, Jakub Jelinek wrote:
On Thu, Sep 03, 2015 at 01:09:23PM +0200, Sebastian Huber wrote:
We have only thread attributes in this function: mutable_attr and attr. The
attr is initialized with &gomp_thread_attr and gomp_thread_attr is supposed
to be read-only by this function. Under certain conditions we have to modify
the initial attributes. Since gomp_thread_attr is read-only, we have to copy
it and then modify the copy. For this we need some storage: mutable_attr.
So use local_thread_attr if you want to stress it, but IMHO thread_attr
just just fine. I really don't like mutable_attr.
Ok, if I don't rename thread_attr, is the patch ok?
Yes.
Thanks a lot for your kind review.
I committed the patches as:
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227439
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227440
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227441
https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=227442
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber@embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.