This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [c++-delayed-folding] fold_simple


On 08/31/2015 03:43 PM, Kai Tietz wrote:
2015-08-31 21:29 GMT+02:00 Jason Merrill <jason@redhat.com>:
On 08/31/2015 03:08 PM, Kai Tietz wrote:

I will need to verify that this patch doesn't introduce regressions.
The wacky thing here is the encapsulation of overflowed-arguments in
maybe_constant_value function by nop-expr.


Do we need to worry about that?  If one of the operands is overflowed, we
don't care whether the result is overflowed.

Well, we would introduce, if we don't see in condition that operand
already overflowed, double overflow-warning, which seems to be
something we avoided until now.  So I would say, it matters.

I would rather handle this by checking whether the folded operands are constant before even building the folded result.

Jason


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]