This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[nvptx] fix complex args
- From: Nathan Sidwell <nathan at acm dot org>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Cc: Bernd Schmidt <bernds_cb1 at t-online dot de>
- Date: Sun, 23 Aug 2015 10:45:56 -0400
- Subject: [nvptx] fix complex args
- Authentication-results: sourceware.org; auth=none
I've committed this patch, which fixes gcc.dg/compat/struct-by-value-11
That test passes 'complex char', which is split into two char arguments. We
fail to promote the type in one place, leading to a PTX type mismatch where we
claim an 8 bit type is a 32 bit type.
nathan
2015-08-23 Nathan Sidwell <nathan@acm.org>
* config/nvptx/nvptx.c (walk_args_for_param): Promote arg reg
decls.
(nvptx_declare_function_name): Insert formatting tabs for
consistency.
Index: config/nvptx/nvptx.c
===================================================================
--- config/nvptx/nvptx.c (revision 227101)
+++ config/nvptx/nvptx.c (working copy)
@@ -1,4 +1,3 @@
-
/* Target code for NVPTX.
Copyright (C) 2014-2015 Free Software Foundation, Inc.
Contributed by Bernd Schmidt <bernds@codesourcery.com>
@@ -413,10 +412,10 @@ walk_args_for_param (FILE *file, tree ar
i++;
if (write_copy)
fprintf (file, "\tld.param%s %%ar%d, [%%in_ar%d];\n",
- nvptx_ptx_type_from_mode (mode, false), i, i);
+ nvptx_ptx_type_from_mode (mode, true), i, i);
else
fprintf (file, "\t.reg%s %%ar%d;\n",
- nvptx_ptx_type_from_mode (mode, false), i);
+ nvptx_ptx_type_from_mode (mode, true), i);
}
}
}
@@ -546,7 +545,7 @@ nvptx_declare_function_name (FILE *file,
else if (TYPE_MODE (result_type) != VOIDmode)
{
machine_mode mode = arg_promotion (TYPE_MODE (result_type));
- fprintf (file, ".reg%s %%retval;\n",
+ fprintf (file, "\t.reg%s %%retval;\n",
nvptx_ptx_type_from_mode (mode, false));
}
@@ -618,10 +617,10 @@ nvptx_declare_function_name (FILE *file,
walk_args_for_param (file, TYPE_ARG_TYPES (fntype), DECL_ARGUMENTS (decl),
true, return_in_mem);
if (return_in_mem)
- fprintf (file, "ld.param.u%d %%ar1, [%%in_ar1];\n",
+ fprintf (file, "\tld.param.u%d %%ar1, [%%in_ar1];\n",
GET_MODE_BITSIZE (Pmode));
if (stdarg_p (fntype))
- fprintf (file, "ld.param.u%d %%argp, [%%in_argp];\n",
+ fprintf (file, "\tld.param.u%d %%argp, [%%in_argp];\n",
GET_MODE_BITSIZE (Pmode));
}