This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch ARM/AArch64] Add missing is_neon_type types
- From: Ramana Radhakrishnan <ramana dot radhakrishnan at foss dot arm dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Fri, 14 Aug 2015 10:33:37 +0100
- Subject: Re: [Patch ARM/AArch64] Add missing is_neon_type types
- Authentication-results: sourceware.org; auth=none
- References: <1439544183-23202-1-git-send-email-james dot greenhalgh at arm dot com>
On 14/08/15 10:23, James Greenhalgh wrote:
>
> Hi,
>
> I spotted that these are missing from the "is_neon_type" attribute:
>
> neon_fp_abs_s, neon_fp_abs_s_q, neon_fp_abs_d, neon_fp_abs_d_q,
> neon_fp_neg_s, neon_fp_neg_s_q, neon_fp_neg_d, neon_fp_neg_d_q,
> neon_fp_to_int_d, neon_fp_to_int_d_q,
> neon_int_to_fp_d, neon_int_to_fp_d_q,
>
> This patch adds them. In principle this could have shown up by allowing
> us to create a limited set of conditional neon instructions, or as a
> scheduling quirk in the Cortex-A7 and Cortex-A53 scheduling models, but I
> didn't see any impact in some smoke testing.
>
> Bootstrapped on arm-none-linux-gnueabihf and aarch64-none-linux-gnu with
> no issues.
This is OK -
Thanks for catching this.
Ramana
>
> OK?
>
> Thanks,
> James
>
> ---
> 2015-08-14 James Greenhalgh <james.greenhalgh@arm.com>
>
> * config/arm/types.md (is_neon_type): Add missing types.
>