This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [BUILDROBOT] Go runtime: calling â__builtin_frame_addressâ with a nonzero argument is unsafe

From: Jeff Law <law at redhat dot com>
To: Martin Sebor <msebor at gmail dot com>, Jan-Benedict Glaw <jbglaw at lug-owl dot de>
Cc: Segher Boessenkool <segher at kernel dot crashing dot org>, Martin Sebor <msebor at redhat dot com>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>
Date: Mon, 3 Aug 2015 09:29:40 -0600
Subject: Re: [BUILDROBOT] Go runtime: calling â__builtin_frame_addressâ with a nonzero argument is unsafe
Authentication-results: sourceware.org; auth=none
References: <555E2FC6 dot 60804 at redhat dot com> <555E50A5 dot 60309 at redhat dot com> <557A0617 dot 6040605 at redhat dot com> <55B1C845 dot 1030000 at redhat dot com> <20150725142035 dot GB7309 at gate dot crashing dot org> <55B6F232 dot 2080402 at gmail dot com> <20150728142406 dot GA14409 at gate dot crashing dot org> <55B7A368 dot 3060200 at gmail dot com> <55BBA5A2 dot 8040709 at redhat dot com> <55BEA48F dot 9020808 at gmail dot com> <20150803115544 dot GB24297 at lug-owl dot de> <55BF7F2D dot 2040605 at gmail dot com>

On 08/03/2015 08:48 AM, Martin Sebor wrote:

On 08/03/2015 05:55 AM, Jan-Benedict Glaw wrote:

On Sun, 2015-08-02 17:15:27 -0600, Martin Sebor <msebor@gmail.com> wrote:

OK for the trunk.  Sorry for the delay.


Thank you. Committed in revision 226480.


...und breaks native builds. When doing builds using config-list.mk, I
first build a GCC for the build machine, then re-build a
cross-configured GCC with that.


I don't know if pragma GCC diagnostic is valid in Go (still waiting
for my build to finish to confirm) but disabling the warning in
cases where the calls are known to be safe should fix the compilation
error.

My understanding is the runtime is shared across gcc-go and golang. Sothe push/pop diagnostics may not be appropriate.


Ian Taylor should have the final say about the best way forward.

Jeff

References:
- Re: [PATCH] warn for unsafe calls to __builtin_return_address
  - From: Martin Sebor
- [BUILDROBOT] Go runtime: calling â__builtin_frame_addressâ with a nonzero argument is unsafe (was: warn for unsafe calls to __builtin_return_address)
  - From: Jan-Benedict Glaw
- Re: [BUILDROBOT] Go runtime: calling â__builtin_frame_addressâ with a nonzero argument is unsafe
  - From: Martin Sebor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]