This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing

From: Mikael Morin <mikael dot morin at sfr dot fr>
To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>, Richard Biener <richard dot guenther at gmail dot com>
Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 30 Jul 2015 16:08:47 +0200
Subject: Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing
Authentication-results: sourceware.org; auth=none
Authentication-results: sfrmc.priv.atos.fr; dkim=none (no signature); dkim-adsp=none (no policy) header dot from=mikael dot morin at sfr dot fr
References: <20150721190814 dot GA32735 at troutmask dot apl dot washington dot edu> <55B77DF4 dot 3070209 at sfr dot fr> <20150728131925 dot GA63678 at troutmask dot apl dot washington dot edu> <CAFiYyc3hNxWq+61dZMpSZRJmXjzE5mP0ZXDq+ab7bhvk6jM8Mg at mail dot gmail dot com> <55B89E0B dot 1030506 at sfr dot fr> <CAFiYyc382CODQXomL9AMm+Zf3Z5E2zX6xA-Hi6Z03NaRM7OASQ at mail dot gmail dot com> <55B8C028 dot 1000409 at sfr dot fr> <CAFiYyc3Dk66hfuO6P4TcuqDHjgmRP1=2EAm_59jiZSO3SQ_iPA at mail dot gmail dot com> <20150729164552 dot GA12035 at troutmask dot apl dot washington dot edu>

Le 29/07/2015 18:45, Steve Kargl a écrit :

On Wed, Jul 29, 2015 at 02:04:12PM +0200, Richard Biener wrote:

On Wed, Jul 29, 2015 at 1:59 PM, Mikael Morin <mikael.morin@sfr.fr> wrote:

Le 29/07/2015 13:22, Richard Biener a écrit :


On Wed, Jul 29, 2015 at 11:34 AM, Mikael Morin <mikael.morin@sfr.fr>
wrote:


Le 29/07/2015 10:26, Richard Biener a écrit :



Did you try using vec_safe_splice?




That handles NULL retargs, not NULL or empty arglist.

I think retargs is NULL.



Not if the patch fixes anything.

The case retargs == NULL is the case arglen == 0, which means every vector
pointer we are about to splice is NULL.
So the patch fixes it.


Ok, that wasn't obvious from reading the patch.


This builds and passes regression testing on x86_64-*-freebsd.
OP found the problem by running the sanatizers.  I don't
know how to build gcc with this as a build option.  I'll
commit whichever diff you recommend.

I prefer this second variant.
OK for trunk without further comment from Richi.
Thanks.

Mikael

References:
- [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing
  - From: Steve Kargl
- Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing
  - From: Mikael Morin
- Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing
  - From: Steve Kargl
- Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing
  - From: Richard Biener
- Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing
  - From: Mikael Morin
- Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing
  - From: Richard Biener
- Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing
  - From: Mikael Morin
- Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing
  - From: Richard Biener
- Re: [PATCH] PR fortran/66942 -- avoid referencing a NULL C++ thing
  - From: Steve Kargl

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]