This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function
- From: Segher Boessenkool <segher at kernel dot crashing dot org>
- To: tbsaunde+gcc at tbsaunde dot org
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sat, 25 Jul 2015 10:59:19 -0500
- Subject: Re: [PATCH 4/4] define ASM_OUTPUT_LABEL to the name of a function
- Authentication-results: sourceware.org; auth=none
- References: <1437791820-17927-1-git-send-email-tbsaunde+gcc at tbsaunde dot org> <1437791820-17927-5-git-send-email-tbsaunde+gcc at tbsaunde dot org>
On Fri, Jul 24, 2015 at 10:37:00PM -0400, tbsaunde+gcc@tbsaunde.org wrote:
> --- a/gcc/config/pa/pa.c
> +++ b/gcc/config/pa/pa.c
> @@ -9761,6 +9761,18 @@ pa_reloc_rw_mask (void)
> return 3;
> }
>
> +/* Assemble a lable. */
Typo.
> +void
> +pa_output_label (FILE *f, const char *label)
> +{
> + assemble_name (f, label);
> + if (TARGET_GAS)
> + fputs (":\n", f);
> + else
> + fputc ('\n', (f));
You forgot to remove the extra parens here :-)
If so many targets use default_assemble_label, can you make it an actual
default instead of defining it everywhere?
Segher