This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PR64164] drop copyrename, integrate into expand
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: David Edelsohn <dje dot gcc at gmail dot com>, Alexandre Oliva <aoliva at redhat dot com>, Jeff Law <law at redhat dot com>, Segher Boessenkool <segher at kernel dot crashing dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Christophe Lyon <christophe dot lyon at linaro dot org>, Eric Botcazou <ebotcazou at adacore dot com>
- Date: Fri, 24 Jul 2015 05:10:31 -0700
- Subject: Re: [PR64164] drop copyrename, integrate into expand
- Authentication-results: sourceware.org; auth=none
- References: <orwpzcv2a2 dot fsf at livre dot home> <CAFiYyc38hY5jfVx-92f1i2aZKMVynPt1YrdWCObX3T45a_2V3Q at mail dot gmail dot com> <ork2u0imrg dot fsf at free dot home> <CAFiYyc1FQkwXDo0pKXkLmc-pgN9zAG2_+ru0TQsVQRWgVUqR1w at mail dot gmail dot com> <ory4ifhkkg dot fsf at free dot home> <ora8ut3oh6 dot fsf at livre dot home> <CAFiYyc3Dq3CycGg=YoD+eCbSBkPUHfpG-o5OhBag4Da8L3SwTQ at mail dot gmail dot com> <orio9cw10j dot fsf at livre dot home> <CAFiYyc3k9xh_6RGbTdHYOJ-aEmUWVeFRoWy=YzCHFDNSdtTXCA at mail dot gmail dot com> <orwpxqvqnp dot fsf at livre dot home> <20150723203112 dot GB27818 at gate dot crashing dot org> <CAMe9rOpR+2gPxo0tKaRPtcML_Q4=r-_=9iqk+_JZFPkM=eN=BQ at mail dot gmail dot com> <CAMe9rOpbLEyDexVJqJAFJ3W6o4AktNog-jwk2CY4GZkrmT+nfA at mail dot gmail dot com> <CAGWvny=phfwrxBpwdvDJ0G_Y0ZuTC2dJEe0LMGxsb62M25__vA at mail dot gmail dot com> <CAMe9rOrnXqRQtX4w534RGFTdoYxP2_s2fEwh50uo2tPy3zxzpA at mail dot gmail dot com> <CAFiYyc113OZHECjZTj5XPg4oH9Rpeea6a1y=Tpvu3T7abxB0pw at mail dot gmail dot com>
On Fri, Jul 24, 2015 at 2:22 AM, Richard Biener
<richard.guenther@gmail.com> wrote:
> On Fri, Jul 24, 2015 at 1:19 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Thu, Jul 23, 2015 at 4:14 PM, David Edelsohn <dje.gcc@gmail.com> wrote:
>>> On Thu, Jul 23, 2015 at 5:59 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>> On Thu, Jul 23, 2015 at 1:57 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>>> On Thu, Jul 23, 2015 at 1:31 PM, Segher Boessenkool
>>>>> <segher@kernel.crashing.org> wrote:
>>>>>> On Thu, Jul 23, 2015 at 12:29:14PM -0300, Alexandre Oliva wrote:
>>>>>>> Yeah. Thanks, I've tested it with this change, and I'm now checking
>>>>>>> this in (full patch first; adjusted incremental patch at the end):
>>>>>>
>>>>>> Unfortunately it causes about a thousand test fails on powerpc64-linux
>>>>>> (at least, it seems to be this patch, I haven't actually checked).
>>>>>>
>>>>>
>>>>> It also caused:
>>>>>
>>>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66978
>>>>>
>>>>
>>>> and maybe:
>>>>
>>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66983
>>>
>>> I request that this patch be reverted (again).
>>
>> And I request to test any new patches under x32 before checking in.
>> You can use Ubuntu 14 to test x32.
>
> x32 is neither primary nor secondary arch.
>
I suggested a way to reproduce the problem. I checked in this testcase so
that the problem will show up on Linux/x86-64.
--
H.J.
---
Index: ChangeLog
===================================================================
--- ChangeLog (revision 226149)
+++ ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2015-07-24 H.J. Lu <hongjiu.lu@intel.com>
+
+ PR bootstrap/66978
+ * gcc.target/i386/pr66978.c: New test.
+
2015-07-24 Andreas Krebbel <krebbel@linux.vnet.ibm.com>
* gcc.target/s390/gpr2fprsavecfi.c: New test.
Index: gcc.target/i386/pr66978.c
===================================================================
--- gcc.target/i386/pr66978.c (revision 0)
+++ gcc.target/i386/pr66978.c (working copy)
@@ -0,0 +1,15 @@
+/* { dg-do compile { target { ! { ia32 } } } } */
+/* { dg-require-effective-target maybe_x32 } */
+/* { dg-options "-O2 -mx32 -maddress-mode=short" } */
+
+extern int foo (int *);
+int
+bar (int *p)
+{
+ __attribute__ ((noinline, noclone))
+ int hack_digit (void)
+ {
+ return foo (p);
+ }
+ return hack_digit ();
+}
- References:
- Re: [PR64164] drop copyrename, integrate into expand
- Re: [PR64164] drop copyrename, integrate into expand
- Re: [PR64164] drop copyrename, integrate into expand
- Re: [PR64164] drop copyrename, integrate into expand
- Re: [PR64164] drop copyrename, integrate into expand
- Re: [PR64164] drop copyrename, integrate into expand
- Re: [PR64164] drop copyrename, integrate into expand
- Re: [PR64164] drop copyrename, integrate into expand
- Re: [PR64164] drop copyrename, integrate into expand
- Re: [PR64164] drop copyrename, integrate into expand
- Re: [PR64164] drop copyrename, integrate into expand
- Re: [PR64164] drop copyrename, integrate into expand
- Re: [PR64164] drop copyrename, integrate into expand
- Re: [PR64164] drop copyrename, integrate into expand