This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fix in-tree-binutils builds
- From: Mike Stump <mikestump at comcast dot net>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Jan Beulich <JBeulich at suse dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Binutils <binutils at sourceware dot org>
- Date: Thu, 23 Jul 2015 11:23:42 -0700
- Subject: Re: [PATCH] fix in-tree-binutils builds
- Authentication-results: sourceware.org; auth=none
- References: <55A62FD90200007800091184 at mail dot emea dot novell dot com> <CAMe9rOo6G-73GXdaK5_EU_YXmfVUhdt5iSO8eCr=1qgFPLV6Bg at mail dot gmail dot com> <27496A41-4C23-49C5-93B7-9387FDB8BF8C at mrs dot kithrup dot com> <CAMe9rOqqJ3VuGBPs9oS3zWgyJV359bo2m83pvs=qNpVM0h=gEw at mail dot gmail dot com> <CAMe9rOr4Efh2fnzRYu+v4jFODZRV82ET9QZYzqAbWWoa5QGXDg at mail dot gmail dot com>
On Jul 23, 2015, at 7:47 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Jul 17, 2015 at 7:43 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Wed, Jul 15, 2015 at 9:47 AM, Mike Stump <mrs@mrs.kithrup.com> wrote:
>>> On Jul 15, 2015, at 9:07 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>> On Wed, Jul 15, 2015 at 1:03 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>>
>>>>> - $gcc_cv_as_gas_srcdir/configure.in \
>>>>> + $gcc_cv_as_gas_srcdir/configure.[ai][cn] \
>>>>> $gcc_cv_as_gas_srcdir/Makefile.in ; do
>>>>> gcc_cv_gas_version=`sed -n -e 's/^[[ ]]*VERSION=[[^0-9A-Za-z_]]*\([[0-9]]*\.[[0-9]]*.*\)/VERSION=\1/p' < $f`
>>>>
>>>> How portable is [ai][cn]?
>>>
>>> Should be portable enough.
>>
>> Are there any objections to this patch?
>
> Can we check in this patch?
I’m not a build system nor a global reviewer so i have no more authority to say yes than you.
Seems kinda obvious and trivial to me. The goal of fixing in-tree binutils builds seems reasonable to me.