This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PR64164] drop copyrename, integrate into expand
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: Jeff Law <law at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Christophe Lyon <christophe dot lyon at linaro dot org>, David Edelsohn <dje dot gcc at gmail dot com>, Eric Botcazou <ebotcazou at adacore dot com>
- Date: Wed, 22 Jul 2015 14:33:16 -0300
- Subject: Re: [PR64164] drop copyrename, integrate into expand
- Authentication-results: sourceware.org; auth=none
- References: <orvbhmz59m dot fsf at livre dot home> <orego9x6zw dot fsf at livre dot home> <551A2C7C dot 8060005 at redhat dot com> <orvbhdz6yy dot fsf at livre dot home> <5522AF73 dot 5000706 at redhat dot com> <or1tjajnl8 dot fsf at livre dot home> <CAFiYyc0Map6+zB1Cp89Njm5kAFBK2ibroxzPSLdUs2v=BM46iw at mail dot gmail dot com> <orpp59bpui dot fsf at livre dot home> <orwpzcv2a2 dot fsf at livre dot home> <CAFiYyc38hY5jfVx-92f1i2aZKMVynPt1YrdWCObX3T45a_2V3Q at mail dot gmail dot com> <ork2u0imrg dot fsf at free dot home> <CAFiYyc1FQkwXDo0pKXkLmc-pgN9zAG2_+ru0TQsVQRWgVUqR1w at mail dot gmail dot com> <ory4ifhkkg dot fsf at free dot home> <ora8ut3oh6 dot fsf at livre dot home> <CAFiYyc3Dq3CycGg=YoD+eCbSBkPUHfpG-o5OhBag4Da8L3SwTQ at mail dot gmail dot com>
On Jul 21, 2015, Richard Biener <richard.guenther@gmail.com> wrote:
> On Sat, Jul 18, 2015 at 9:37 AM, Alexandre Oliva <aoliva@redhat.com> wrote:
>> + if (cfun->gimple_df)
> If the cfun->gimple_df check is to decide whether this is a call or a function
> then no, this can't work reliably. What is this test for else?
It turns out it's not call or function, as I thought at first, but
gimplifying or expanding the function. split_complex_args is not used
for calls. So the above might actually work (minus the misleading
comments I wrote), and I think it's cleaner than adding a bool
expanding_p arg to split_complex_args and
assign_parms_augmented_arg_list, called from gimplify_parameters (during
gimplification of a function) and assign_parms (during its expansion).
Do you agree, or would you prefer the explicit argument?
--
Alexandre Oliva, freedom fighter http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/ FSF Latin America board member
Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer