Re: Tests for libgomp based on OpenMP Examples 4.0.2.

[Maxim Blumental <bvmaks at gmail dot com>]

 Corrected log and patch.

2015-07-22 17:12 GMT+03:00 Jakub Jelinek <jakub@redhat.com>:
> On Wed, Jul 22, 2015 at 04:55:09PM +0300, Maxim Blumental wrote:
>> 2015-07-22  Maxim Blumenthal  <maxim.blumenthal@intel.com>
>>
>>       PR libgomp/66950
>>       * testsuite/libgomp.c/examples-4/simd-7.c: Lower the defined constant
>>       N to 30.  Add iterative reference function for Fibonacci numbers
>>       - fib_ref.
>
> Incorrect changelog.  It should be:
>         * testsuite/libgomp.c/examples-4/simd-7.c (N): Change to 30 from 45.
>         (fib_ref): New function.
>
>>       (fib): Correct corner cases in the recursion.
>
> Why the n == 2 special case?  I think only the if (n <= 1) return n;
> case is really needed.
>
>>       (main): Replace the non-simd loop with fib_ref call.
>>       * testsuite/libgomp.fortran/examples-4/simd-7.f90: Add iterative
>>       reference subroutine for Fibonacci numbers - fib_ref.
>
> See above for ChangeLog entry issue.
>
>>       (fibonacci): Lower the parameter N to 30.  Correct accordingly check for
>>       the last array element value.  Replace the non-simd loop with fib_ref
>>       call.  Remove redundant b_ref array.  Remove the comparison of the last
>>       array element with according Fibbonacci sequence element.
>>       (fib): Correct corner cases in the recursion.
>
> See above for n == 2 special case.
>
>         Jakub



-- 


---------------------
Sincerely yours,
Maxim Blumental

Attachment: ChangeLog.txt
Description: Text document

Attachment: fib_fix.patch
Description: Binary data