This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gomp4] New nvptx pattern and internal builtin

From: Bernd Schmidt <bernds at codesourcery dot com>
To: Nathan Sidwell <nathan at acm dot org>, <gcc-patches at gnu dot org>
Date: Mon, 20 Jul 2015 15:37:52 +0200
Subject: Re: [gomp4] New nvptx pattern and internal builtin
Authentication-results: sourceware.org; auth=none
References: <55A92142 dot 6050008 at codesourcery dot com> <55ACF556 dot 5000306 at acm dot org>

On 07/20/2015 03:19 PM, Nathan Sidwell wrote:

I was looking at adding another target builtin, and found this code
rather convoluted.  It seemed to have been cloned from somewhere more
complicated -- for instance, nvptx_expand_binop_builtin's comment
discusses a MACFLAG argument, which is nowhere to be seen.

Okay, I admit to tuning out comments for code that I know, and I didn'tnotice that one. As for being convoluted - this is pretty much thestandard structure for the machine specific builtins which is used in alot of ports.

I ended up reimplementing using a single array describing the builtins
and allowing direct indexing using the builtin number, rather than
iteration when expanding.

If you really want to, that's fine, but note the point about consistencywith other ports.



Bernd

References:
- [gomp4] New nvptx pattern and internal builtin
  - From: Bernd Schmidt
- Re: [gomp4] New nvptx pattern and internal builtin
  - From: Nathan Sidwell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]