This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Allow REG_EQUAL for ZERO_EXTRACT

From: Kugan <kugan dot vivekanandarajah at linaro dot org>
To: Jeff Law <law at redhat dot com>, Maxim Kuvyrkov <maxim dot kuvyrkov at linaro dot org>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Mon, 20 Jul 2015 13:17:46 +1000
Subject: Re: [PATCH 1/2] Allow REG_EQUAL for ZERO_EXTRACT
Authentication-results: sourceware.org; auth=none
References: <558FD9D5 dot 9070703 at linaro dot org> <558FDA78 dot 9030606 at linaro dot org> <F76C1ECD-DD43-415F-A896-BE7EA6A5330F at linaro dot org> <559212EF dot 7080301 at linaro dot org> <44190061-8CD0-417F-8592-23EC3C0BB9A3 at linaro dot org> <5599BAE4 dot 80103 at linaro dot org> <559AEF4C dot 6060506 at redhat dot com>

I have made a mistake while addressing the review comments for this
patch. Unfortunately, It was not detected in my earlier testing. My
sincere graphology for the mistake.

I have basically missed the STRICT_LOW_PART check for the first if-check
thus the second part (which is the ZERO_EXTRACT part) will never get
executed. Attached patch fixes this along with some minor changes.

Bootstrapped and regression tested on arm-none-linux (Chromebook) and
x86-64-linux-gnu with no new regression along with the ARM ennoblement
patch.

Also did a complete arm qemu regression testing with Chriophe's scripts
with no new regression.
(http://people.linaro.org/~christophe.lyon/cross-validation/gcc-test-patches/225987-reg4/report-build-info.html)

Is this OK for trunk,


Thanks,
Kugan

ïgcc/ChangeLog:

2015-07-20  Kugan Vivekanandarajah  <kuganv@linaro.org>

	* cse.c (cse_insn): Fix missing check for STRICT_LOW_PART and minor
	clean up.

Attachment: p.txt
Description: Text document

Follow-Ups:
- Re: [PATCH 1/2] Allow REG_EQUAL for ZERO_EXTRACT
  - From: Jeff Law
- Re: [PATCH 1/2] Allow REG_EQUAL for ZERO_EXTRACT
  - From: Andreas Schwab

References:
- Re: [PATCH 1/2] Allow REG_EQUAL for ZERO_EXTRACT
  - From: Kugan
- Re: [PATCH 1/2] Allow REG_EQUAL for ZERO_EXTRACT
  - From: Jeff Law

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]