This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: fixup gomp register/unregister prototypes
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Nathan Sidwell <nathan at acm dot org>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 17 Jul 2015 17:48:35 +0200
- Subject: Re: fixup gomp register/unregister prototypes
- Authentication-results: sourceware.org; auth=none
- References: <55A6AEBE dot 5090406 at acm dot org> <20150717144417 dot GM1780 at tucnak dot redhat dot com> <55A922EF dot 6050107 at acm dot org>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Jul 17, 2015 at 11:44:47AM -0400, Nathan Sidwell wrote:
> On 07/17/15 10:44, Jakub Jelinek wrote:
> >On Wed, Jul 15, 2015 at 03:04:30PM -0400, Nathan Sidwell wrote:
> >>I'm almost tempted to commit as obvious. I noticed that the callers of
> >>these functions from code generated by mkoffload declare the 2nd arg as an
> >>int, because they have no visibility of the enum. I thought it wise to make
> >>the definitions match.
> >
> >I think it doesn't really matter that much, such an enum on all targets we care
> >about is passed the same way as int.
> >
> >But if you think it is important, I don't really care either way.
>
> Having been bitten by fshort-enums on ARM, I like to be careful :)
That is an ABI changing option, though perhaps somebody might build libgomp
for that ABI. Ok then.
Jakub